tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
Couple of nits. LGTM otherwise. ================ Comment at: clang/include/clang/Driver/Options.td:827 +def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, + HelpText<"Pass <arg> to the offload linker identified by <triple>">, + MetaVarName<"<arg> <triple>">, Group<Link_Group>; ---------------- The comment may need updating now. ================ Comment at: clang/include/clang/Driver/Options.td:828 + HelpText<"Pass <arg> to the offload linker identified by <triple>">, + MetaVarName<"<arg> <triple>">, Group<Link_Group>; def Xpreprocessor : Separate<["-"], "Xpreprocessor">, Group<Preprocessor_Group>, ---------------- I think this is backwards. I think the first one here should be `<triple>` (the one joined with `-Xoffload-linker`), followd by `<arg>` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126226/new/ https://reviews.llvm.org/D126226 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
