aaron.ballman added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:9118 + ProcessDeclAttributeOptions Options; + Options.IncludeCXX11Attributes = AL.isCXX11Attribute(); + ProcessDeclAttribute(*this, nullptr, ASDecl, AL, Options); ---------------- rsmith wrote: > aaron.ballman wrote: > > rsmith wrote: > > > This seems to be equivalent to setting `IncludeCXX11Attributes` to > > > `true`, which seems to be equivalent to not setting it at all. > > Hmmm, not quite -- `AL.isCXX11Attribute()` may return `false` (like for the > > GNU spelling of this attribute). > It might, but we only care about the value of `IncludeCXX11Attributes` when > processing a C++11 attribute, so it doesn't matter how this flag is set for a > non-C++11 attribute. Oh, good observation, you're right! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
