ChuanqiXu added inline comments.
================ Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:699 + Guard = new llvm::GlobalVariable(getModule(), Int8Ty, /*isConstant=*/false, + llvm::GlobalVariable::InternalLinkage, + llvm::ConstantInt::get(Int8Ty, 0), ---------------- ChuanqiXu wrote: > Should the Guard be internal linkage? I image that it is possible to be > manipulated by different TUs. So I feel like it might be better to be > linkonce or linkonce_odr? Oh, I realized I'm wrong. Don't remind this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
