c-rhodes added inline comments.

================
Comment at: clang/test/Sema/aarch64-sve-vector-arith-ops.c:23
-  (void)(i8 + f64); // expected-error{{invalid operands to binary expression}}
-  (void)(i8 + 0);   // expected-error{{invalid operands to binary expression}}
-  (void)(i8 + 0l);  // expected-error{{invalid operands to binary expression}}
----------------
DavidTruby wrote:
> c-rhodes wrote:
> > I think these vector + imm tests should be removed in D126380 but fine to 
> > keep here if it's easier
> Ah yes I missed this, you're correct but I will be pushing the two patches at 
> the same time so I guess it doesn't matter much except for correct history? 
> Happy to change it though.
> Ah yes I missed this, you're correct but I will be pushing the two patches at 
> the same time so I guess it doesn't matter much except for correct history? 
> Happy to change it though.

Yeah no worries keep them in here, thanks for clarifying


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126377/new/

https://reviews.llvm.org/D126377

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to