MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:257 + } else if (Scope != "none") { + D.Diag(diag::err_invalid_sls_hardening) << Scope << A->getAsString(Args); + } ---------------- The convention is `err_drv_unsupported_option_argument`. Don't add a new kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits