Anastasia marked 12 inline comments as done.
================
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+ }
+ // Could have events and/or vaargs.
+ if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
----------------
bader wrote:
> [Style] Minor suggestion to consider.
> To avoid indentation of almost 100 lines of code inside if statement this can
> be implemented as:
> if (NumArgs < 5) llvm_unreachable("Unhandled enqueue_kernel signature");
>
> There is no else branch for that condition anyway.
Would assertion be more appropriate even?
================
Comment at: lib/Sema/SemaChecking.cpp:145
@@ +144,3 @@
+ }
+ // Potentially emit standard warnings for implicit conversions if enabled
+ // using -Wconversion.
----------------
I am reusing C diagnostics functionality here now to keep consistency!
http://reviews.llvm.org/D20249
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
