tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Object/OffloadBinary.cpp:28
+ if (identify_magic(Buf.getBuffer()) != file_magic::offload_binary)
return errorCodeToError(llvm::object::object_error::parse_failed);
----------------
It could be just `object_error::parse_failed` now. Applies to the return above,
too.
================
Comment at: llvm/unittests/Object/OffloadingTest.cpp:8
+using namespace llvm;
+using namespace object;
+
----------------
Nit: `using namespace llvm::object;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126812/new/
https://reviews.llvm.org/D126812
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
