Hi Xiang, I would be more than happy to test the fix for you :). Though it is 11:45 pm for me now and I am going to bed. But I can take a look tomorrow.
Thanks, Shubham > On Jun 1, 2022, at 11:42 PM, stan li <python3k...@outlook.com> wrote: > > Hi Shubham, > > I found one issue in the change. > But I don’t have a Mac environment to test. > Could you help to test if this fix the issue? > > The patch is in attachment. > > Thanks > Xiang > > > Sent from Mail <https://go.microsoft.com/fwlink/?LinkId=550986> for Windows > > From: Shubham Sandeep Rastogi via Phabricator > <mailto:revi...@reviews.llvm.org> > Sent: Wednesday, June 1, 2022 11:28 PM > To: python3k...@outlook.com <mailto:python3k...@outlook.com>; > sven.vanhaastr...@arm.com <mailto:sven.vanhaastr...@arm.com>; > andrew.savonic...@gmail.com <mailto:andrew.savonic...@gmail.com>; > chris.biene...@me.com <mailto:chris.biene...@me.com>; goyor...@gmail.com > <mailto:goyor...@gmail.com>; anastasia.stul...@arm.com > <mailto:anastasia.stul...@arm.com> > Cc: srastog...@apple.com <mailto:srastog...@apple.com>; tha...@chromium.org > <mailto:tha...@chromium.org>; mask...@google.com <mailto:mask...@google.com>; > cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>; > mgo...@gentoo.org <mailto:mgo...@gentoo.org>; bhuvanendra.kum...@amd.com > <mailto:bhuvanendra.kum...@amd.com>;1135831...@qq.com > <mailto:1135831...@qq.com>; gandhi21...@gmail.com > <mailto:gandhi21...@gmail.com>; aeuba...@google.com > <mailto:aeuba...@google.com>; mlek...@skidmore.edu > <mailto:mlek...@skidmore.edu>; blitzrak...@gmail.com > <mailto:blitzrak...@gmail.com>; shen...@google.com > <mailto:shen...@google.com>;david.gr...@arm.com <mailto:david.gr...@arm.com>; > simon.m...@emea.nec.com <mailto:simon.m...@emea.nec.com> > Subject: [PATCH] D125052: [HLSL] Enable vector types for hlsl. > > rastogishubham added a comment. > > Hi, this patch causes an issue with the CMake Xcode build configuration, if I > try to use xcode as the generator with CMake, using the build command: > > xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug > -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang > -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' > -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" > -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm > > I get: > > CMake Error in > /Users/shubham/Development/llvm-project/clang/lib/Headers/CMakeLists.txt: > The custom command generating > > > /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h > > is attached to multiple targets: > > hlsl-resource-headers > clang-resource-headers > > but none of these is a common dependency of the other(s). This is not > allowed by the Xcode "new build system". > > > CMake Error in > /Users/shubham/Development/llvm-project/third-party/benchmark/CMakeLists.txt: > The custom command generating > > > /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h > > is attached to multiple targets: > > hlsl-resource-headers > clang-resource-headers > > but none of these is a common dependency of the other(s). This is not > allowed by the Xcode "new build system". > > > CMake Generate step failed. Build files cannot be regenerated correctly. > > This is similar to the issue that was found in this patch: > https://reviews.llvm.org/D123498 <https://reviews.llvm.org/D123498> > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D125052/new/ > <https://reviews.llvm.org/D125052/new/> > > https://reviews.llvm.org/D125052 <https://reviews.llvm.org/D125052> > > <header_install.patch>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
