thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land.
Looking pretty good! ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7620 + std::vector<std::string> Arches = {"IA32"}; + SupportedArches.insert(Arches.begin(), Arches.end()); + } ---------------- Just `SupportedArches.push_back("IA32")` seems a bit simpler. (Or use append_range, but there's really no need) ================ Comment at: clang/test/Driver/cl-zc.cpp:47 +// KERNEL-X64-AVX2: error: invalid argument '/arch:AVX2' not allowed with '/kernel' +// KERNEL-X64-AVX512: error: invalid argument '/arch:AVX512' not allowed with '/kernel' + ---------------- Tests for interaction of /kernel with /GR and /EH would be nice too, as mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits