MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM from my perspective, but this needs someone else's review.
================
Comment at: llvm/tools/llvm-driver/llvm-driver.cpp:50
+ bool ConsumeFirstArg = false;
+ if (LaunchedTool == "llvm") {
+ if (Argc < 2)
----------------
abrachet wrote:
> MaskRay wrote:
> > Some distributions may want to use something like llvm-15. See some binary
> > utilities how the version is handled.
> Thank's I've taken this from objcopy's code
The format of `cl::PrintVersionMessage();` is not so good for user-facing
tools. Consider omitting it.
`llvm-objcopy --version` should probably use a style similar to `clang
--version` but the priority isn't high.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109977/new/
https://reviews.llvm.org/D109977
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
