hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clang/include/clang/Driver/Options.td:6463 Alias<W_Joined>, AliasArgs<["no-invalid-source-encoding"]>; +def _SLASH_external_W0 : CLFlag<"external:W0">, HelpText<"Ignore warnings from system headers with -Wno-system-headers">, Alias<Wno_system_headers>; +def _SLASH_external_W1 : CLFlag<"external:W1">, HelpText<"Enable -Wsystem-headers">, Alias<Wsystem_headers>; ---------------- For the help text, the "with -Wno-system-headers" part seems redundant. How about: `Ignore warnings from system headers (default)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
