mmuetzel added a comment.

In D126291#3573607 <https://reviews.llvm.org/D126291#3573607>, @mstorsjo wrote:

> FWIW, something very similar was added just a couple days ago in an lldb 
> specific lit.cfg.py: https://reviews.llvm.org/D127048#change-KJ7QgKPHtN1S

Thank you for pointing this out.
Those feature definitions for the lldb subproject probably stem from around 
here:
https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/lit.cfg.py#L65

Instead of every subproject adding their own conditions for similar features, 
would it make sense to move these definitions to somewhere where all 
subprojects could use those same lit features? Would that be in 
`/llvm/utils/lit/lit/llvm/config.py`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to