dblaikie added a comment.

In D111521#3584439 <https://reviews.llvm.org/D111521#3584439>, @alok wrote:

> Re-based and updated to include one negative testcase.
> I could not find a test for VarDecl with DynamicInitKind::NoStub. There are 
> constructors for other DynamicInitKind but not for NoStub. Please help me in 
> case you are aware of the condition when it is produced.

I've got no particular knowledge of OpenMP unfortunately - the suggestion was 
based on looking at the conditions in the code & wanting them to all be tested.

If it can't be tested, could the test in the code be replaced with an assertion 
that it never happens?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111521/new/

https://reviews.llvm.org/D111521

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D111521: [DebugI... Alok Kumar Sharma via Phabricator via cfe-commits
    • [PATCH] D111521: [D... David Blaikie via Phabricator via cfe-commits

Reply via email to