lei added a comment. Please document all new functions added.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); ---------------- amyk wrote: > Can we add some brief documentation for this function, like what is done for > other functions in this file? feels like this should be written to just take either 1 param or multiple params via vararg.. since the 2 arg are not really related in any way. ================ Comment at: clang/lib/Sema/SemaExpr.cpp:9567 + if (areAnyVectorTypesAltivec(RHSType, LHSType) && + !areVectorTypesSameElmType(RHSType, LHSType)) + Diag(RHS.get()->getExprLoc(), diag::warn_deprecated_lax_vec_conv_all) ---------------- clang-format ================ Comment at: clang/lib/Sema/SemaExpr.cpp:10519 + if (areAnyVectorTypesAltivec(RHSType, LHSType) && + !areVectorTypesSameElmType(RHSType, LHSType)) + Diag(Loc, diag::warn_deprecated_lax_vec_conv_all) << RHSType << LHSType; ---------------- clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits