lei added inline comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:7716 +// This returns true if at least one of the types is an altivec vector. +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert((DestTy->isVectorType() || SrcTy->isVectorType()) && ---------------- maybe rename to `anyAltivecTypes()`? ================ Comment at: clang/lib/Sema/SemaExpr.cpp:7738 +// This returns true if both vectors have the same element type. +bool Sema::areVectorTypesSameElmType(QualType SrcTy, QualType DestTy) { + assert((DestTy->isVectorType() || SrcTy->isVectorType()) && ---------------- rename suggestion: haveSameVectorElemTypes() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits