jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land.
More consistency is good and update for downstream users mechanical, so LGTM ================ Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_SCF_TRANSFORMS_H_ -#define MLIR_DIALECT_SCF_TRANSFORMS_H_ +#ifndef MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_ +#define MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_ ---------------- Transforms transforms feels a bit strange, for many others I believe this would have been passes file (which is also not that accurate, patterns and passes would be more, but most others it is just passes and convenient shorthand). Keeping the move mostly mechanical is good though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128049/new/ https://reviews.llvm.org/D128049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
