Author: Kazu Hirata Date: 2022-06-18T10:41:26-07:00 New Revision: 80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d
URL: https://github.com/llvm/llvm-project/commit/80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d DIFF: https://github.com/llvm/llvm-project/commit/80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d.diff LOG: [clang] Call *set::insert without checking membership first (NFC) Added: Modified: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp clang/lib/Sema/SemaExpr.cpp clang/utils/TableGen/ClangAttrEmitter.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp index 370b420b80755..4759932a696f1 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -457,8 +457,7 @@ Value *Environment::createValueUnlessSelfReferential( QualType PointeeType = Type->castAs<ReferenceType>()->getPointeeType(); auto &PointeeLoc = createStorageLocation(PointeeType); - if (!Visited.contains(PointeeType.getCanonicalType())) { - Visited.insert(PointeeType.getCanonicalType()); + if (Visited.insert(PointeeType.getCanonicalType()).second) { Value *PointeeVal = createValueUnlessSelfReferential( PointeeType, Visited, Depth, CreatedValuesCount); Visited.erase(PointeeType.getCanonicalType()); @@ -475,8 +474,7 @@ Value *Environment::createValueUnlessSelfReferential( QualType PointeeType = Type->castAs<PointerType>()->getPointeeType(); auto &PointeeLoc = createStorageLocation(PointeeType); - if (!Visited.contains(PointeeType.getCanonicalType())) { - Visited.insert(PointeeType.getCanonicalType()); + if (Visited.insert(PointeeType.getCanonicalType()).second) { Value *PointeeVal = createValueUnlessSelfReferential( PointeeType, Visited, Depth, CreatedValuesCount); Visited.erase(PointeeType.getCanonicalType()); diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 68634c5495cb9..ce7706ab96cac 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -14473,8 +14473,7 @@ static void RecordModifiableNonNullParam(Sema &S, const Expr *Exp) { if (!FD->hasAttr<NonNullAttr>() && !Param->hasAttr<NonNullAttr>()) return; if (FunctionScopeInfo *FD = S.getCurFunction()) - if (!FD->ModifiedNonNullParams.count(Param)) - FD->ModifiedNonNullParams.insert(Param); + FD->ModifiedNonNullParams.insert(Param); } /// CheckIndirectionOperand - Type check unary indirection (prefix '*'). diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index 1a73b300cf9df..b6bcd851c6c1d 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -4321,9 +4321,8 @@ void EmitClangAttrParsedAttrKinds(RecordKeeper &Records, raw_ostream &OS) { if (Attr.isSubClassOf("TargetSpecificAttr") && !Attr.isValueUnset("ParseKind")) { AttrName = std::string(Attr.getValueAsString("ParseKind")); - if (Seen.find(AttrName) != Seen.end()) + if (!Seen.insert(AttrName).second) continue; - Seen.insert(AttrName); } else AttrName = NormalizeAttrName(StringRef(Attr.getName())).str(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits