sgatev added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:76 +class UncheckedOptionalAccessDiagnosis { +public: ---------------- samestep wrote: > samestep wrote: > > sgatev wrote: > > > Move this to a new UncheckedOptionalAccessDiagnosis.(h,cpp)? > > OK! I'll do that next. > Actually, @sgatev would that go under `FlowSensitive/Models/` or just under > `FlowSensitive/`? I suggest keeping it under `FlowSensitive/Models/` for now. We can change that at a later point if there's a better alternative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits