NoQ added a comment.

Looks great, thanks!



================
Comment at: clang/docs/LibASTMatchersReference.html:2041
+
+Example matches "abcd"
+  NSString *s = @"abcd";
----------------
I think it's more appropriate for this documentation to mention the entire 
literal so that the reader didn't assume that `@` is a different AST node that 
needs to be captured separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128103/new/

https://reviews.llvm.org/D128103

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to