vext01 added inline comments.
================ Comment at: llvm/docs/DeveloperPolicy.rst:419-421 -Your first commit to a repository may require the autogenerated email to be -approved by a moderator of the mailing list. -This is normal and will be done when the mailing list owner has time. ---------------- aaron.ballman wrote: > vext01 wrote: > > aaron.ballman wrote: > > > vext01 wrote: > > > > aaron.ballman wrote: > > > > > Rather than get rid of this, I think we might actually want to > > > > > broaden it. I read this blurb as letting folks know that sometimes > > > > > commit messages take a while before they show up on the commit list. > > > > > It used to be the primary way that happened was when making a commit > > > > > for the first time. Now it happens most often for large commits (due > > > > > to the size of the email content) or a long list of CCs (often added > > > > > automatically by Herald, though the moderation of these has gotten > > > > > better in recent history). > > > > > > > > > > I think it's kind of helpful to let people know that sometimes the > > > > > automated emails get caught out by moderation. But if others don't > > > > > think that's of value to mention, then we can go ahead and remove > > > > > this bit. > > > > Actually, now I read it again, I realise that I don't understand what > > > > this sentence means: > > > > > > > > > Your first commit to a repository may require the autogenerated email > > > > > to be approved by a moderator of the mailing list. > > > > > > > > My first commit to a llvm repository was via github, and github doesn't > > > > discriminate. If you have write-access to the repo, then your push to > > > > `main` will surely go ahead. There are no automated emails involved as > > > > far as I know. > > > > > > > > I suspect this prose is from pre-github, where the process was > > > > different? > > > > Actually, now I read it again, I realise that I don't understand what > > > > this sentence means: > > > > > > Ah, I think I see where the confusion may be coming in. > > > > > > We have a post-commit hook that pushes all commits to a commits email > > > list: https://lists.llvm.org/pipermail/cfe-commits/ (as an example, > > > there's also commits list for LLVM and others), and it's existed for a > > > *long time*. It used to be that your commits were written to the commits > > > list as though they came from you directly (e.g., > > > https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20130225/074838.html), > > > and these days they come in as though from a list bot (e.g., > > > https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20220627/424937.html); > > > check out the from line just below the title to spot the differences. So > > > the old issue was that when you first pushed a commit, you may not have > > > been subscribed to cfe-commits and your commit message wouldn't make it > > > to the lists. Now the issue is that when you push any commit, it might be > > > caught up by moderation filters (this also used to be an issue, but it > > > wasn't the most likely issue for people to hit). > > OK, so what do you recommend we do? This prose is currently full of > > historic details that are confusing/intimidating for a newbie. > > > > Does the sentence still apply, or can we kill it? > Do you think something along these lines is still intimidating for a newbie? > > "For external tracking purposes, committed changes are automatically > reflected on a commits mailing list (link to llvm-commits archive, link to > cfe-commits archive) soon after the commit lands. Note, these mailing lists > are moderated and it is not unusual for a large commit to require a moderator > to approve the email, so do not be concerned if a commit does not immediately > appear in the archives." > > Or something along these lines? Basically, I think it's useful for people to > know that the commit is automatically reflected somewhere (so your commit > messages are more visible than just git log/blame) and that's it's not > something you need to worry about as a committer if you don't see your commit > immediately because all the emails get reflected eventually. That makes a lot more sense to me. I'll make that change and supply a revised diff. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
