hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment.
LGTM! ================ Comment at: llvm/docs/DeveloperPolicy.rst:88 +#. Patches should be unified diffs with "infinite context" (i.e. using something + like `git diff -U999999 main`). + ---------------- vext01 wrote: > hubert.reinterpretcast wrote: > > Using `git diff` like this, there are risks that `main` is now ahead of > > your branch's base. Probably safer to use `HEAD~n` where `n` is the number > > of commits you have on your branch. > > > The exact command you want to issue is going to vary according to > circumstance and personal workflow preference. Sometimes `main` is fine, if > it isn't `HEAD~n` is fine, but if you have a lot of commits then determining > (i.e. manually counting) `n` will be impractical and you probably want to > just use an absolute git hash. > > I don't think we need to delve into a great level of detail. I think the > prose "using something like" is adequate. okay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llvm.org/D128645 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
