MaskRay added inline comments.
================ Comment at: clang/lib/Basic/Targets/RISCV.h:144 + + StringRef LayoutEndianness = Triple.isLittleEndian() ? "e" : "E"; + ---------------- gbenyei wrote: > MaskRay wrote: > > You may use a `char` and possibly fold this into the expression below. > Concatenating a conditional char and a string literal might be tricky, I'm > not sure there is a cleaner solution. There is a constructor `Twine(char)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits