MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan.
================ Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown \ +// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK ---------------- Use one line for RUN. This isn't long. Delete excess spaces. `x86_64-unknown-unknown` can be simplified as `x86_64` ================ Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:2 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown \ +// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK + ---------------- Delete `--check-prefixes=CHECK`. This is the default. ================ Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:4 + +// CHECK-NOT: fpext +// CHECK-NOT: fptrunc ---------------- The test only has negative patterns. Such a test is prone to be stale without being noticed. Add some positive CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
