MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:655
+ if (isa<GlobalIFunc>(Aliasee)) {
+ return;
+ }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
================
Comment at: llvm/test/LTO/alias-indirect-function-lto.c:1
+// RUN: clang -flto %s -c -o %t1
+void f() __attribute__((ifunc("g")));
----------------
llvm/test/ tests cannot use clang. You need to use tools like llvm-lto2. See
existing tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129009/new/
https://reviews.llvm.org/D129009
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
