owenpan added a comment.

In D129057#3627748 <https://reviews.llvm.org/D129057#3627748>, @curdeius wrote:

> LGTM. Thanks for addressing my comments.

Thank you for your quick review and good comments as always!



================
Comment at: clang/unittests/Format/FormatTest.cpp:7136
                Style);
+  verifyFormat("Constructor() : // NOLINT\n"
+               "    aaaa(aaaa) {}",
----------------
curdeius wrote:
> How about very long comments? They don't get split now? Please add a test case
Now trailing comments don't wrap after the colon, but long ones still get split 
and aligned as usual.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129057/new/

https://reviews.llvm.org/D129057

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to