jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land.
LG, let's update the test script first though. See below. ================ Comment at: clang/test/OpenMP/irbuilder_simdlen.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -fopenmp-enable-irbuilder -verify -fopenmp -fopenmp-version=45 -x c++ -triple x86_64-unknown-unknown -emit-llvm %s -o - | FileCheck %s +// expected-no-diagnostics ---------------- psoni2628 wrote: > jdoerfert wrote: > > The check lines look auto-generated and then modified by hand. Why is that? > I originally took `irbuilder_simd.cpp` and modified it to include `simdlen`. > I have now auto-generated the check lines. I see. Auto generated is great, but you don't actually check the metadata anymore. Add `--check-globals` to the update script command. You might also want to teach the script about access group metadata, see D101742 for an example how to do this. ================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:610 + /// \param Simdlen The Simdlen length to apply to the simd loop. + void applySimdlen(CanonicalLoopInfo *Loop, llvm::ConstantInt *Simdlen); + ---------------- As mentioned before. No `llvm::`. This is not MLIR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
