leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.

LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes.

Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd 
or flang until they're needed there? Not sure in this case if this will need 
+2s from their respective owners.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to