MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land.
This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions. Otherwise the change just introduces some CMake variables which cannot be tested. Since you haven't touched flang, compiler-rt, etc. The patch should not updated their CMake files. For lld/ELF, I've created D129406 <https://reviews.llvm.org/D129406> to add the support. It will need to wait until you have landed these zstd changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
