pow2clk added a comment.

I'm confused by the ways this option is allowed to be specified



================
Comment at: clang/include/clang/Driver/Options.td:6824
+class DXCJoinedOrSeparateConflict<string name> : Option<["--", "/", "-"], name,
+  KIND_JOINED_OR_SEPARATE>, Group<dxc_Group>, Flags<[DXCOption, 
NoXarchOption]>;
 
----------------
I'm not sure why this has the suffix "Conflict" In addition, you can't 
currently specify the "I" option with "--" in DXC.


================
Comment at: clang/test/Driver/dxc_I.hlsl:1
+// RUN: %clang_dxc -I test.h  -### %s 2>&1 | FileCheck %s
+
----------------
test.h is kind of a funny name for a directory. 🤔 Maybe just call it "test"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to