zhouyizhou created this revision.
zhouyizhou added reviewers: njames93, nridge, alexfh_, stephenkelly.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
zhouyizhou requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Hi,
I think we should add add preposition "of" to code annotation of
ElseAfterReturnCheck ;-)
Many Thanks Zhouyi
Zhouyi Zhou <zhouzho...@gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D129953
Files:
clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
Index: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
@@ -263,7 +263,7 @@
if (!WarnOnConditionVariables)
return;
if (IsLastInScope) {
- // If the if statement is the last statement its enclosing statements
+ // If the if statement is the last statement of its enclosing statements
// scope, we can pull the decl out of the if statement.
DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
<< ControlFlowInterruptor
@@ -299,7 +299,7 @@
if (!WarnOnConditionVariables)
return;
if (IsLastInScope) {
- // If the if statement is the last statement its enclosing statements
+ // If the if statement is the last statement of its enclosing statements
// scope, we can pull the decl out of the if statement.
DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
<< ControlFlowInterruptor
Index: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp
@@ -263,7 +263,7 @@
if (!WarnOnConditionVariables)
return;
if (IsLastInScope) {
- // If the if statement is the last statement its enclosing statements
+ // If the if statement is the last statement of its enclosing statements
// scope, we can pull the decl out of the if statement.
DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
<< ControlFlowInterruptor
@@ -299,7 +299,7 @@
if (!WarnOnConditionVariables)
return;
if (IsLastInScope) {
- // If the if statement is the last statement its enclosing statements
+ // If the if statement is the last statement of its enclosing statements
// scope, we can pull the decl out of the if statement.
DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
<< ControlFlowInterruptor
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
