bcl5980 added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128
+ // to the function itself; it points to a stub for the compiler.
+ // FIXME: We also need to emit an entry thunk.
+ SmallString<256> MangledName;
----------------
A headache thing here.
We need to get the function definition with triple x64 to define entry thunk.
For now the function definition here is aarch64 version.
For example the case in Microsoft doc "Understanding Arm64EC ABI and assembly
code":
```
struct SC {
char a;
char b;
char c;
};
int fB(int a, double b, int i1, int i2, int i3);
int fC(int a, struct SC c, int i1, int i2, int i3);
int fA(int a, double b, struct SC c, int i1, int i2, int i3) {
return fB(a, b, i1, i2, i3) + fC(a, c, i1, i2, i3);
}
```
x64 version IR for fA is:
```
define dso_local i32 @fA(i32 noundef %a, double noundef %b, ptr nocapture
noundef readonly %c, i32 noundef %i1, i32 noundef %i2, i32 noundef %i3)
local_unnamed_addr #0 { ... }
```
aarch64 version IR for fA is:
```
define dso_local i32 @"#fA"(i32 noundef %a, double noundef %b, i64 %c.coerce,
i32 noundef %i1, i32 noundef %i2, i32 noundef %i3) #0 {...}
```
Arm64 will allow any size structure to be assigned to a register directly. x64
only allows sizes 1, 2, 4 and 8.
Entry thunk follow x64 version function type. But we only have aarch64 version
function type.
I think the best way to do is create a x64 version codeGenModule and use the
x64 CGM to generate the function type for entry thunk. But it is hard for me to
do here. I tried a little but a lot of issues happen.
One other way is only modify `AArch64ABIInfo::classifyArgumentType`, copy the
x64 code into the function and add a flag to determine which version will the
function use. It is easier but I'm not sure it is the only difference between
x64 and aarch64. Maybe the classify return also need to do this. And it is not
a clean way I think.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125418/new/
https://reviews.llvm.org/D125418
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
