jhuber6 added a comment.

Let me know if I should move this code somewhere else, or if there are 
problems. One change I made is that the constant is `weak_odr` and `hidden` 
instead of `linkonce_odr` and `protected`. This is so this constant is alive 
until link time, AMDGPU pretty much always uses LTO so these should be 
optimized out when we internalize symbols. I'm assuming we don't need 
`protected` visibility as these shouldn't be read from another executable (e.g. 
the host).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to