vitalybuka added a comment.

I am not sure what to do with this patch. I really prefer to avoid it to 
minimize the risk of regressions.

We probably considered/prototyped to insert starts like in this solution then 
in 2016. But at the time of the solution was a comment by @rsmith 
https://reviews.llvm.org/D24693#559609
Even if it works for asan, I still don't know how this patch will affect 
miss-compiles in other places. Dropping intrinsics completely as is must not 
miscompile.

If the goal to fix asan, then it's extremely rare case, I measured it on llvm 
codebase and entire Google code. This is not worth of effort to me.
Also HWAsan and MTE, which can be considered asan successors, does not even 
bother to handle allocas with multiple lifetime start.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129448/new/

https://reviews.llvm.org/D129448

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to