awarzynski added a comment.

What about similar code in LLVM 
<https://github.com/llvm/llvm-project/blob/2224bbcd7409c54770d1eaaed527e8dd344acfef/llvm/cmake/modules/CMakeLists.txt#L100-L107>?



================
Comment at: clang/cmake/modules/CMakeLists.txt:35
 # via CMAKE_MODULE_PATH, place API modules next to it.
+# Copy without source permissions because the source could be read-only
 file(COPY .
----------------
[nit] This comment tells me "what" is happening here, but that can be deduced 
from the code (i.e. `NO_SOURCE_PERMISSIONS` --> copy without source 
permissions). Explaining "why" this being read-only is a problem would be more 
helpful, IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130254/new/

https://reviews.llvm.org/D130254

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D130254: [CMake... Sebastian Neubauer via Phabricator via cfe-commits
    • [PATCH] D130254: [... Andrzej Warzynski via Phabricator via cfe-commits

Reply via email to