shafik added inline comments.
================ Comment at: clang/lib/AST/DeclCXX.cpp:899 + // triviality properties of the class until selecting a destructor and + // computing the eligibility of SMFs. This is because those member + // functions may have constraints that we need to evaluate and compare ---------------- I think we should spell out `Special Member Function` instead of using `SMF` ================ Comment at: clang/lib/Sema/SemaDecl.cpp:17875 + return true; + if (!Context.hasSameType(M1->getParamDecl(0)->getType(), + M2->getParamDecl(0)->getType())) ---------------- What happens if we have further parameters with default arguments? Unless I am missing something they are still special member functions but the proposal does not seem to cover them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
