aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a typo fix in a comment. One thing worth thinking about is
whether it would be worth it to have a diagnostic for valid C code in older
modes that will change behavior in C2x due to this feature, but that can be
done as follow-up work.
================
Comment at: clang/lib/Lex/Lexer.cpp:1469
// so we need to check both tables.
- // '_' doesn't have the XID_Continue property but is allowed in C++.
+ // '_' doesn't have the XID_Continue property but is allowed in C an C++.
static const llvm::sys::UnicodeCharSet XIDStartChars(XIDStartRanges);
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130416/new/
https://reviews.llvm.org/D130416
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
