kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/Protocol.h:1782 unsigned endCharacter; - std::string kind; + FoldingRangeKind kind; }; ---------------- hokein wrote: > sorry for not being clear on my previous comment, I think the current `string > kind;` is good, and it aligns with the LSP one. > > what I suggest was adding string literals to FoldingRange, something like > > > ``` > struct FoldingRange { > const static llvm::StringLiteral REGION_KIND; > const static llvm::StringLiteral COMMENT_KIND; > const static llvm::StringLiteral IMPORT_KIND; > > // other fields keep as-is. > ... > } > ``` > we're diverging from the LSP structure. +1, we already have the same pattern for code action kinds, i was also referring to this in our offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits