jpenix-quic marked 2 inline comments as done. jpenix-quic added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Flang.cpp:52 + options::OPT_fno_automatic, + options::OPT_fconvert_EQ}); } ---------------- awarzynski wrote: > jpenix-quic wrote: > > Reading through https://reviews.llvm.org/D95460 again, I'm not sure this is > > the appropriate place to add . I am marking this as a TODO that I will > > revisit with the other feedback! > You can use `AddOtherOptions` instead. `AddFortranDialectOptions` is more > about language options. Is this a language option? It's a bit of a > borderline. Feel free to add another hook too. > > Btw, the reformatting is an unrelated change. Could you submit in a separate > patch? Thanks! I went the `AddOtherOptions` route for now. Apologies for the unrelated change and thank you for checking over this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
