ychen marked 2 inline comments as done.
ychen added a comment.
In D129954#3686780 <https://reviews.llvm.org/D129954#3686780>, @nikic wrote:
> LGTM. After some further consideration, implementing this properly in LLVM
> would probably take more effort than is worthwhile (especially as this is
> target-specific functionality, so we'd actually have to expose TTI queries
> for this, etc.)
Agreed. Thanks for the review.
================
Comment at: clang/test/CodeGen/inline-asm-x86-flag-output.c:378
+
+int test_assume_boolean_flag(long nr, volatile long *addr) {
+ //CHECK-LABEL: @test_assume_boolean_flag
----------------
nikic wrote:
> You might want to check that we're doing the right thing if there are
> multiple output constraints (via extractvalue).
That's a good idea. Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129954/new/
https://reviews.llvm.org/D129954
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
