erichkeane added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:13540
         ED->getValueRange(Max, Min);
+        --Max;
 
----------------
I don't think this is the correct answer.  Even though the other use of this 
seems to 'work', `getValueRange` is still returning wrapped values here.  The 
fix is to figure out how to fix the math in getValueRange, and change the 
sanitizer's IR generation if necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130811/new/

https://reviews.llvm.org/D130811

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to