aaron.ballman added a comment.
Thanks for the typo fixes! All the changes look correct to me, so LGTM. Do you
need someone to land this on your behalf? If so, what name and email address
would you like used for patch attribution?
================
Comment at: clang/lib/Headers/opencl-c.h:17856
+intel_sub_group_avc_sic_payload_t __ovld intel_sub_group_avc_sic_configure_ipe(
+ uchar luma_intra_partition_mask, uchar intra_neighbour_availability,
uchar left_edge_luma_pixels, uchar upper_left_corner_luma_pixel,
----------------
GabrielRavier wrote:
> junaire wrote:
> > Not sure if we want to format this...
> Well, it is what clang-format did, so I don't really know... Is it also
> legacy code as mentioned above ?
I think it's fine to reformat this given that the code is being updated. I
validated that the only identifiers changed here are parameter names (so
there's no chance to break user code).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130827/new/
https://reviews.llvm.org/D130827
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
