hubert.reinterpretcast added inline comments.
================ Comment at: libcxx/trunk/include/istream:1223 + __state |= ios_base::badbit; return -1; } ---------------- @ldionne, another dubious aspect of this patch is that it initializes `__r` to `0` and never sets it. Seems like this line should have been to set `__r` and not to return directly. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49863/new/ https://reviews.llvm.org/D49863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits