ashay-github added inline comments.

================
Comment at: llvm/cmake/modules/TableGen.cmake:147
+  cmake_parse_arguments(ADD_TABLEGEN "${options}" "${oneValueArgs}"
+    "${multiValueArgs}" ${ARGN})
+
----------------
nikic wrote:
> I think it would be fine to write this as just 
> `cmake_parse_arguments(ADD_TABLEGEN "" "OPTIONS" "" ${ARGN})`, but don't feel 
> strongly about that.
Thanks! Rewrote it as `cmake_parse_arguments(ADD_TABLEGEN "" "DESTINATION" "" 
${ARGN})`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131282/new/

https://reviews.llvm.org/D131282

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to