wyt added a reviewer: xazax.hun.
wyt added inline comments.
Herald added a subscriber: rnkovacs.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:103
+ virtual void transferCFGElement(const CFGElement *Element, Lattice &L,
+ Environment &Env) {}
+
----------------
gribozavr2 wrote:
> Instead of adding virtual function, please continue following the CRTP
> pattern. Add the expected function declarations in the comment above the
> class.
> Instead of adding virtual function, please continue following the CRTP
> pattern. Add the expected function declarations in the comment above the
> class.
As discussed, moving to a CRTP pattern causes the code to break as they have
not been implemented by users yet. Added a FIXME to do so after users have been
migrated to implement transferCFGElement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131614/new/
https://reviews.llvm.org/D131614
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
