vaibhav.y added inline comments.

================
Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:75
+            emitFilename(FE->getName(), Loc.getManager());
+        // FIXME: No current way to add file-only location to SARIF object
+      }
----------------
abrahamcd wrote:
> @vaibhav.y , just wanted to confirm, the SarifDiagnosticWriter can only add 
> locations that include row/column numbers, correct?
Yes, this is currently not supported. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131632/new/

https://reviews.llvm.org/D131632

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to