ckandeler added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:546
+ bool VisitPredefinedExpr(PredefinedExpr *E) {
+ H.addToken(E->getLocation(), HighlightingKind::Macro);
+ return true;
----------------
sammccall wrote:
> actually, would HighlightingKind::LocalVariable be more appropriate?
>
> The standard calls this a "The function-local predefined variable".
>
> Admittedly I have a tendency to think of it as macro-like by analogy with
> `__LINE__` etc but this model is observably wrong: it breaks down with
> templates and in other ways.
Hm, yes, I was not aware it was specified explicitly as a local variable. Will
change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131175/new/
https://reviews.llvm.org/D131175
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
