tschuett added inline comments.
================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:44 + + enum CommandKind { + CK_CC1, ---------------- Why is this not an enum class? ================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:80 + + static bool classof(const Command *C) { return C->getKind() == CK_Simple; } +}; ---------------- Why are all members public? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132405/new/ https://reviews.llvm.org/D132405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits