mmasten added a comment.

Thanks for reviewing. One concern I have going forward is the number of entries 
that will appear in the switch statement inside 
addVectorizableFunctionsFromVecLib(). I assume that the right thing to do is to 
replace this with something that is TableGen'd? Also, I just wanted to point 
out that some of these entries will result in svml calls that are not legal. 
E.g., __svml_sinf32 does not actually exist in the library, but can be 
legalized in case one explicitly sets a vector length of 32. Although these 
types of cases are probably not common, I wanted to bring this to your 
attention since the legalization piece of this work will be reviewed and 
committed separately. If needed, I can remove those entries until the 
legalization is in place.


https://reviews.llvm.org/D19544



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to