erichkeane added a comment.
Nothing suspicious as far as I can tell, other than just punting on
ArrayFillers. Don't understand enough of this code to just do a straight-up
approval though, so hopefully one of the other reviewers can take a look and
confirm with another uninformed opinion :)
================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:535
+
+ // TODO: Fillers?
+ if (const auto *InitList = dyn_cast<InitListExpr>(Initializer)) {
----------------
Heh, THIS is a huge "TODO" here. The ArrayFillers go through a ton of
twists/turns in the current interpreter, as array-filler initializers can be
massive. Do we have a way to avoid allocating space for
filled-but-not-referenced values in this interpreter?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132727/new/
https://reviews.llvm.org/D132727
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
