MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow. Herald added a subscriber: pengfei. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
Some PS4/PS45 tests include the line `REQUIRES: x86-registered-target` meaning they depend on having the X86 backend included in the build. This should not be necessary since the driver understands all triples regardless of which backends are included. The change removes all unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132950 Files: clang/test/Driver/ps4-pic.c clang/test/Driver/ps4-ps5-header-search.c clang/test/Driver/ps4-ps5-linker-non-win.c clang/test/Driver/ps4-ps5-linker-win.c clang/test/Driver/ps4-ps5-relax-relocations.c clang/test/Driver/ps4-ps5-runtime-flags.c clang/test/Driver/ps4-sdk-root.c clang/test/Driver/ps4ps5base.c clang/test/Driver/ps5-pic.c clang/test/Driver/ps5-sdk-root.c
Index: clang/test/Driver/ps5-sdk-root.c =================================================================== --- clang/test/Driver/ps5-sdk-root.c +++ clang/test/Driver/ps5-sdk-root.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - /// (Essentially identical to ps4-sdk-root.c except for the target.) /// Check that PS5 clang doesn't report a warning message when locating Index: clang/test/Driver/ps5-pic.c =================================================================== --- clang/test/Driver/ps5-pic.c +++ clang/test/Driver/ps5-pic.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - // Test the driver's control over the PIC behavior for PS5 compiler. // These consist of tests of the relocation model flags and the // pic level flags passed to CC1. Index: clang/test/Driver/ps4ps5base.c =================================================================== --- clang/test/Driver/ps4ps5base.c +++ clang/test/Driver/ps4ps5base.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - // Test that the driver always emits -fno-use-init-array on the PS4/PS5 targets // since their ABI does not support the .init_array section. Index: clang/test/Driver/ps4-sdk-root.c =================================================================== --- clang/test/Driver/ps4-sdk-root.c +++ clang/test/Driver/ps4-sdk-root.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - // Check that PS4 clang doesn't report a warning message when locating // system header files (either by looking at the value of SCE_ORBIS_SDK_DIR // or relative to the location of the compiler driver), if "-nostdinc", Index: clang/test/Driver/ps4-ps5-runtime-flags.c =================================================================== --- clang/test/Driver/ps4-ps5-runtime-flags.c +++ clang/test/Driver/ps4-ps5-runtime-flags.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target -// /// Test the profile runtime library to be linked for PS4/PS5 compiler. /// Check runtime flag --dependent-lib which does not append the default library search path. // Index: clang/test/Driver/ps4-ps5-relax-relocations.c =================================================================== --- clang/test/Driver/ps4-ps5-relax-relocations.c +++ clang/test/Driver/ps4-ps5-relax-relocations.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - // RUN: %clang -### -target x86_64-scei-ps4 %s -o - 2>&1 | \ // RUN: FileCheck %s // RUN: %clang -### -target x86_64-scei-ps4 -Wa,-mrelax-relocations=yes %s -o - 2>&1 | \ Index: clang/test/Driver/ps4-ps5-linker-win.c =================================================================== --- clang/test/Driver/ps4-ps5-linker-win.c +++ clang/test/Driver/ps4-ps5-linker-win.c @@ -1,7 +1,7 @@ // This test checks that orbis-ld is used for PS4 linker all the time, and // prospero-lld is used for PS5 linker. Specifying -fuse-ld causes an error. -// REQUIRES: system-windows, x86-registered-target +// REQUIRES: system-windows // RUN: mkdir -p %t // RUN: touch %t/orbis-ld.exe Index: clang/test/Driver/ps4-ps5-linker-non-win.c =================================================================== --- clang/test/Driver/ps4-ps5-linker-non-win.c +++ clang/test/Driver/ps4-ps5-linker-non-win.c @@ -1,6 +1,5 @@ /// Checks proper linker prefixing for PS4 and PS5. // UNSUPPORTED: system-windows -// REQUIRES: x86-registered-target // RUN: mkdir -p %t // RUN: rm -f %t/orbis-ld Index: clang/test/Driver/ps4-ps5-header-search.c =================================================================== --- clang/test/Driver/ps4-ps5-header-search.c +++ clang/test/Driver/ps4-ps5-header-search.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - /// PS4 and PS5 use the same SDK layout, so use the same tree for both. // RUN: env SCE_ORBIS_SDK_DIR=%S/Inputs/scei-ps4_tree %clang -target x86_64-scei-ps4 -E -v %s 2>&1 | FileCheck %s --check-prefix=ENVPS4 // RUN: env SCE_PROSPERO_SDK_DIR=%S/Inputs/scei-ps4_tree %clang -target x86_64-sie-ps5 -E -v %s 2>&1 | FileCheck %s --check-prefix=ENVPS4 Index: clang/test/Driver/ps4-pic.c =================================================================== --- clang/test/Driver/ps4-pic.c +++ clang/test/Driver/ps4-pic.c @@ -1,5 +1,3 @@ -// REQUIRES: x86-registered-target - // Test the driver's control over the PIC behavior for PS4 compiler. // These consist of tests of the relocation model flags and the // pic level flags passed to CC1.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
